Merge pull request #315 from ably/feature-link-onclick

Add support for onClick to FeaturedLink
ably · Feb 13, 2024 · aea9c15 · aea9c15
2 parents b9eb157 + 552010d
commit aea9c15
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 11 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ably-ui (13.1.0)
+    ably-ui (13.2.2.dev.78815ed)
       view_component (>= 2.33, < 2.50)
 
 GEM

diff --git a/lib/ably_ui/version.rb b/lib/ably_ui/version.rb
@@ -1,3 +1,3 @@
 module AblyUi
-  VERSION = '13.2.2'
+  VERSION = '13.2.2.dev.78815ed'
 end
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ably/ui",
-  "version": "13.2.2",
+  "version": "13.2.2-dev.78815ed",
   "description": "Home of the Ably design system library ([design.ably.com](https://design.ably.com)). It provides a showcase, development/test environment and a publishing pipeline for different distributables.",
   "repository": {
     "type": "git",

diff --git a/preview/Gemfile b/preview/Gemfile
@@ -37,7 +37,7 @@ gem 'view_component', '~> 2.33.0', require: 'view_component/engine'
 
 gem 'responders'
 
-gem 'ably-ui', '13.2.2', require: 'ably_ui'
+gem 'ably-ui', '13.2.2.dev.78815ed', require: 'ably_ui'
 
 # https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
 gem 'psych', '< 4'

diff --git a/preview/Gemfile.lock b/preview/Gemfile.lock
@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    ably-ui (13.2.2)
+    ably-ui (13.2.2.dev.78815ed)
       view_component (>= 2.33, < 2.50)
     actioncable (6.0.5.1)
       actionpack (= 6.0.5.1)
@@ -176,7 +176,7 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
-  ably-ui (= 13.2.2)
+  ably-ui (= 13.2.2.dev.78815ed)
   bootsnap (>= 1.4.2)
   byebug
   dotenv-rails

diff --git a/preview/package.json b/preview/package.json
@@ -2,7 +2,7 @@
   "name": "preview",
   "private": true,
   "dependencies": {
-    "@ably/ui": "13.2.2",
+    "@ably/ui": "13.2.2-dev.78815ed",
     "@babel/preset-react": "^7.12.5",
     "@rails/ujs": "^6.0.0",
     "@rails/webpacker": "5.4.4",

diff --git a/preview/yarn.lock b/preview/yarn.lock
@@ -2,10 +2,10 @@
 # yarn lockfile v1
 
 
-"@ably/[email protected]":
-  version "13.2.2"
-  resolved "https://registry.yarnpkg.com/@ably/ui/-/ui-13.2.2.tgz#c6296b4f2fbcfe0c7cc6e9bbdb73fdd37a32def6"
-  integrity sha512-nIozCQJVwuwInKxHWll1GN1pMiVjcfVaqh5BrWOdmq0Xj1GieW5wWM+Zb83h2LleotvbtlMlfwJh2evCy7ms5A==
+"@ably/[email protected]-dev.78815ed":
+  version "13.2.2-dev.78815ed"
+  resolved "https://registry.yarnpkg.com/@ably/ui/-/ui-13.2.2-dev.78815ed.tgz#3b0329452a7d294aab064ee2a196ce6cec7fad43"
+  integrity sha512-JLX8CWo06ZuxfA1m1au0KsNjZ7IMCRtvTMQyljshZqVGJpVjo09Mzj22PheUpcsWlhYZkMYYuHupDr/8qI+NjQ==
   dependencies:
     "@mrtkrcm/cypress-plugin-snapshots" "https://github.com/mrtkrcm/cypress-plugin-snapshots#v1.13.0"
     addsearch-js-client "^0.7.0"

diff --git a/src/core/FeaturedLink/component.jsx b/src/core/FeaturedLink/component.jsx
@@ -30,6 +30,7 @@ const FeaturedLink = ({
   reverse = false,
   additionalCSS = "",
   newWindow = false,
+  onClick = undefined,
   children,
 }) => {
   const targetAndRel = buildTargetAndRel(url, newWindow);
@@ -42,6 +43,7 @@ const FeaturedLink = ({
       } ${additionalCSS}`}
       style={{ "--featured-link-icon-size": `var(${textSize.replace("text", "--fs")})` }}
       {...targetAndRel}
+      onClick={onClick}
     >
       {reverse ? (
         <>
@@ -77,6 +79,7 @@ FeaturedLink.propTypes = {
   reverse: T.bool,
   additionalCSS: T.string,
   newWindow: T.bool,
+  onClick: T.func,
 };
 
 export default FeaturedLink;