Update src/core/Icon/EncapsulatedIcon.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
ably · Oct 30, 2024 · 9967684 · 9967684
1 parent 3df125b
commit 9967684
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/core/Icon/EncapsulatedIcon.tsx b/src/core/Icon/EncapsulatedIcon.tsx
@@ -23,15 +23,20 @@ const EncapsulatedIcon = ({
     baseTheme: "dark",
     theme,
   });
+  const ICON_SIZE_REDUCTION = 12;
+  const ICON_HEIGHT_REDUCTION = 2;
+
   let computedIconSize = size,
     computedIconHeight = size;
 
   if (iconSize) {
     computedIconSize = iconSize;
-  } else if (size.endsWith("px")) {
+  } else if (size.toString().endsWith("px")) {
     const numericalSize = parseInt(size, 10);
-    computedIconSize = `${numericalSize - 12}px`;
-    computedIconHeight = `${numericalSize - 2}px`;
+    computedIconSize = `${numericalSize - ICON_SIZE_REDUCTION}px`;
+    computedIconHeight = `${numericalSize - ICON_HEIGHT_REDUCTION}px`;
+  } else {
+    console.warn(`EncapsulatedIcon: Non-pixel units might not behave as expected`);
   }
 
   return (