Merge pull request #146 from ably/DEX-65-ably-icon-navigation

[DEX-65] support optional icon link
ably · Feb 4, 2022 · 7363cd2 · 7363cd2
2 parents 888ee97 + d80a401
commit 7363cd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/core/Meganav/component.html.erb b/src/core/Meganav/component.html.erb
@@ -2,7 +2,7 @@
   <%= notice %>
 
   <div class="ui-meganav ui-grid-px">
-    <%= render(AblyUi::Core::Logo.new(theme_name: @theme_name, data_id: "meganav-logo", href: url_base)) %>
+    <%= render(AblyUi::Core::Logo.new(theme_name: @theme_name, data_id: "meganav-logo", href: logo_link)) %>
     <%= render(AblyUi::Core::MeganavItemsDesktop.new(theme_name: @theme_name, url_base: url_base)) %>
 
     <% if @session_data[:signedIn] %>

diff --git a/src/core/Meganav/component.rb b/src/core/Meganav/component.rb
@@ -6,21 +6,23 @@ module Core
     class Meganav < ViewComponent::Base
       include MeganavConfig
       include Util
-      attr_reader :options, :login_link, :url_base
+      attr_reader :options, :login_link, :logo_link, :url_base
 
       renders_one :notice, AblyUi::Core::Notice
 
       def initialize(
         session_data: {},
         theme_name: :white,
         login_link: '/login',
+        logo_link: '',
         url_base: AblyUi::Core::Util::DEFAULT_URL_BASE
       )
         @session_data = session_data
         @theme_name = theme_name
         @options = options
         @login_link = login_link
         @url_base = url_base
+        @logo_link = logo_link || url_base
         theme_setup(theme_name)
       end