fix: create stable references for hook dependency arrays: Accordion, …

…Icon
ably · Dec 16, 2024 · 072d2b8 · 072d2b8
1 parent 9cdcbf7
commit 072d2b8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ably/ui",
-  "version": "15.1.8",
+  "version": "15.1.9",
   "description": "Home of the Ably design system library ([design.ably.com](https://design.ably.com)). It provides a showcase, development/test environment and a publishing pipeline for different distributables.",
   "repository": {
     "type": "git",

diff --git a/src/core/Accordion.tsx b/src/core/Accordion.tsx
@@ -155,7 +155,11 @@ const Accordion = ({
       : indexValues.filter((_, index) =>
           options?.defaultOpenIndexes?.includes(index),
         );
-  }, [options?.defaultOpenIndexes, options?.fullyOpen, data.length]);
+  }, [
+    JSON.stringify(options?.defaultOpenIndexes),
+    options?.fullyOpen,
+    data.length,
+  ]);
 
   const [openRowValues, setOpenRowValues] = useState<string | string[]>(
     openIndexes,

diff --git a/src/core/Icon.tsx b/src/core/Icon.tsx
@@ -69,7 +69,7 @@ const Icon = ({
       size,
       color,
       additionalCSS,
-      additionalAttributes,
+      JSON.stringify(additionalAttributes),
       lightSecondaryColor,
       darkSecondaryColor,
     ],