[ECO-4058] Feature/Integration protocol 2 #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntioning connection serial
related tests for the same
1. Set channelSerial when message, presencemessage or attached received 2. Send channelSerial while sending channel attach message 3. Set channelSerial to nil if channel is detached, failed or suspended
1. Retrieving value using create_recovery_key and setting msgserial, channel serials and recover key on connection 2. Handled resume/recover success/failure in connection manager. 3. Deprecated old recovery_key method on connection
1. Added private onAttach method to presence_manager 2. Depending on the has_presence_flag, sync is marked either as started or none 3. Entering local members when onAttach is called 4. Removed client initiated sync from presence code ( as per spec ) 5. Removed entering local members at the end of the sync
This reverts commit 21279fa.
same at all places
1. Send attach only when connection state is CONNECTED 2. Not queue attach message, instead send is immediately on connected 3. Removed use of emitter pattern while clearing attach/detach timers
1. Renamed rest auth extra_auth_headers to client_id_header with both rest/realtime specific impl 2. Added method client_id_header_sync to realtime auth 3. Annotated implementation with right spec
[ECO-4845] Fix wildcard clientId
Made sure client is connected before doing further operations
added recovery_key specific tests
removed unncessary test that checks for invalid server message using connection serial
[ECO-4058][Protocol-2] Feature/integration protocol 2 tests
ttypic
approved these changes
Jul 5, 2024
|
Thanks for approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #378