Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push docstrings updates #420

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Push docstrings updates #420

merged 3 commits into from
Jul 1, 2024

Conversation

owenpearson
Copy link
Member

updates GCM to FCM (GCM was deprecated in favour of FCM), and adds web as a mentioned push target.

GCM transport is deprecated in favour of FCM
@owenpearson owenpearson requested a review from sacOO7 July 1, 2024 12:17
@github-actions github-actions bot temporarily deployed to staging/pull/420/features July 1, 2024 12:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/420/docs July 1, 2024 12:18 Inactive
This was changed server-side so that the endpoint rejects web push
recipients with a string encryptionKey.
Copy link
Contributor

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenpearson owenpearson merged commit 89dc286 into main Jul 1, 2024
23 checks passed
@owenpearson owenpearson deleted the push-docstrings-updates branch July 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants