Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4686] Implement internal presence #405

Closed

Conversation

sacOO7
Copy link
Contributor

@sacOO7 sacOO7 commented May 20, 2024

Commit summary

  • renamed :in_sync enum to :sync_completed, since :in_sync is a very confusing term and doesn't go as per spec.
  • removed resume_sync_proc code that does client initiated sync when channel attaches with has_presence flag. This doesn't go as per spec.
  • added on_attach method to presence_manager that
  1. start or end sync depending on has_presence flag
  2. enter local members when on_attach method is called.
  • Added a new enter_client_with_id method to presence that enters local members with id. Earlier local members were entered at the end of the sync and didn't support entering members with given id.

@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 20, 2024 11:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 20, 2024 11:03 Inactive
@sacOO7 sacOO7 changed the title refactored string check for either nil or empty string [ECO-4686] Refactored string check for either nil or empty string May 20, 2024
@sacOO7 sacOO7 changed the title [ECO-4686] Refactored string check for either nil or empty string [ECO-4686] Implement internal presence May 20, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 21, 2024 12:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 21, 2024 12:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 21, 2024 12:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 21, 2024 12:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 21, 2024 12:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 21, 2024 12:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 21, 2024 14:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 21, 2024 14:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 22, 2024 10:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 22, 2024 10:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 22, 2024 12:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 22, 2024 12:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 23, 2024 11:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 23, 2024 11:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 24, 2024 09:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 24, 2024 09:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 24, 2024 12:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 24, 2024 12:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 28, 2024 08:12 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 28, 2024 08:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/features May 28, 2024 12:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/405/docs May 28, 2024 12:02 Inactive
Removed unnecessary client initiated sync defined using resume_sync method.
@sacOO7 sacOO7 changed the base branch from feature/resume-recover to main June 3, 2024 12:44
@sacOO7 sacOO7 changed the base branch from main to feature/resume-recover June 3, 2024 12:44
@sacOO7 sacOO7 marked this pull request as ready for review June 5, 2024 11:17
@sacOO7
Copy link
Contributor Author

sacOO7 commented Jun 6, 2024

Closing in favor of #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant