-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4686] Implement internal presence #405
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacOO7
changed the title
refactored string check for either nil or empty string
[ECO-4686] Refactored string check for either nil or empty string
May 20, 2024
sacOO7
changed the title
[ECO-4686] Refactored string check for either nil or empty string
[ECO-4686] Implement internal presence
May 20, 2024
Removed unnecessary client initiated sync defined using resume_sync method.
Closing in favor of #410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit summary
:in_sync
enum to:sync_completed
, since:in_sync
is a very confusing term and doesn't go as per spec.resume_sync_proc
code that does client initiated sync when channel attaches withhas_presence
flag. This doesn't go as per spec.on_attach
method topresence_manager
thathas_presence
flagon_attach
method is called.enter_client_with_id
method to presence that enters local members withid
. Earlier local members were entered at the end of the sync and didn't support entering members with given id.