[ECO-4687]Feature/resume recover #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sacOO7
commented
May 3, 2024
•
sacOO7
commented
- Fixed [ably-ruby][no-connection-serial] Implement connection resume/recover #393
- There might be failing tests on the PR. Those will be addressed as a part of [ably-ruby][no-connection-serial] Implement missing internal presence #392 and [ably-ruby][no-connection-serial] Implement code + tests for no-connection-serial #378
sacOO7
force-pushed
the
feature/resume-recover
branch
from
297b3fa to
631b1f8
Compare
sacOO7
changed the title
sacOO7
changed the title
initialize method
There was a problem hiding this comment.
I had a cursory look at this PR. A few comments:
- if you're going to split the work across multiple PRs, then I think you're going to have to be the one responsible for making sure that all of the required spec points end up being implemented, because I don't know what the scope of this PR is meant to be
- there seems to be new code added, does this new code not need tests?
| @@ -62,7 +62,7 @@ class Client | |||
|
|
|||
| # When a recover option is specified a connection inherits the state of a previous connection that may have existed under a different instance of the Realtime library, please refer to the API documentation for further information on connection state recovery | |||
| # @return [String,Nil] | |||
| attr_reader :recover | |||
| attr_accessor :recover | |||
There was a problem hiding this comment.
Why was this changed?
lib/ably/realtime/connection.rb
Outdated
| # of pairs of channel @name@ and current @channelSerial@ for every currently attached channel | ||
| def create_recovery_key | ||
| if key.nil? || key.empty? || state == :closing || state == :closed || state == :failed || state == :suspended | ||
| return "" #RTN16h |
There was a problem hiding this comment.
this spec point doesn't exist?
sacOO7
force-pushed
the
feature/resume-recover
branch
from
2588b9f to
9b25716
Compare
|
@lawrence-forooghian I have created a separate PR with proper commit history -> #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.