Add request id fix for bulk publishes #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
params is the body for the #send_request method when the very is POST/PUT, so the previous code failed with all non-GET requests
Most of the tests were checking that the @request_id param is equal to the request_id in the exception for example. But at no point are we checking that the request_id itself is valid i.e. it could be `nil` and all the tests would pass.
Example warnings emitted for a request that fails but then succeeds is now:
```
warn: Ably::Rest::Client - Retry 1 for get /time {} as initial attempt failed (seq #5g-tSQ): getaddrinfo: nodename nor servname provided, or not known (SocketError)
warn: Ably::Rest::Client - Request SUCCEEDED after 1 retry for get /time {} (seq #5g-tSQ, time elapsed 5.11s)
```
And a request that never succeeds:
```
warn: Ably::Rest::Client - Retry 1 for get /time {} as initial attempt failed (seq #KyefoA): getaddrinfo: nodename nor servname provided, or not known (SocketError)
warn: Ably::Rest::Client - Retry 2 for get /time {} as initial attempt failed (seq #KyefoA): getaddrinfo: nodename nor servname provided, or not known (SocketError)
error: Ably::Rest::Client - Request FAILED after 2 retries for get /time {} (seq #KyefoA, time elapsed 15.02s)
```
See related https://github.com/ably/docs/issues/359
Mixing the test debug failure logger and this new logger is causing unreliable tests when using the new test logger. This implementation is complete with support for blocks and the other logger is now disabled for these tests.
We can get more than 2 warnings, but we will have at least two
mattheworiordan
force-pushed
the
add-request-id-fix-for-bulk-publishes
branch
from
5a060c3 to
58d0bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately @funkyboy's implementation did not have test coverage with the new request ID for publish operations, and such, his work introduced a regression.
This PR fixes that, but also: