Refactored check.yml, removed unnecessary commands to install ca cert…

…ificates
ably · May 2, 2024 · ff686cb · ff686cb
1 parent db1ffe9
commit ff686cb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -29,8 +29,6 @@ jobs:
           TEST_TYPE: ${{ matrix.type }}
           RUBY_VERSION: ${{ matrix.ruby }}
         run: |
-          sudo apt-get update
-          sudo apt-get install ca-certificates
           mkdir junit
           bundle exec parallel_rspec --prefix-output-with-test-env-number --first-is-1 -- spec/${{ matrix.type }}
       - uses: actions/upload-artifact@v3

diff --git a/lib/ably/realtime/channel.rb b/lib/ably/realtime/channel.rb
@@ -332,6 +332,7 @@ def presence
       # @return [Ably::Util::SafeDeferrable]
       #
       def history(options = {}, &callback)
+        # RTL10b
         if options.delete(:until_attach)
           unless attached?
             error = Ably::Exceptions::InvalidRequest.new('option :until_attach is invalid as the channel is not attached' )