Fixed naming convention for client_id_header as per review comment

ably · Jun 25, 2024 · bb4b71f · bb4b71f
1 parent f4d7f2b
commit bb4b71f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/ably/auth.rb b/lib/ably/auth.rb
@@ -413,9 +413,9 @@ def auth_header
     # Extra headers that may be used during authentication
     # spec - RSA7e
     # @return [Hash] headers
-    def client_id_header(realtime=false)
+    def client_id_header(realtime_params=false)
       if options[:client_id] && using_basic_auth?
-        if realtime
+        if realtime_params
           { 'clientId' => options[:client_id] }
         else
           { 'X-Ably-ClientId' => Base64.urlsafe_encode64(options[:client_id]) }

diff --git a/lib/ably/realtime/auth.rb b/lib/ably/realtime/auth.rb
@@ -226,7 +226,7 @@ def auth_header_sync
         auth_sync.auth_header
       end
 
-      def client_id_header_sync
+      def client_id_params_sync
         auth_sync.client_id_header(true)
       end
 

diff --git a/lib/ably/realtime/connection.rb b/lib/ably/realtime/connection.rb
@@ -470,7 +470,7 @@ def create_websocket_transport
                 'false'
               end
 
-              url_params.merge!(client.auth.client_id_header_sync) # RSA7e1
+              url_params.merge!(client.auth.client_id_params_sync) # RSA7e1
               url_params.merge!(client.transport_params)
 
               if !key.nil_or_empty? and connection_state_available?