Skip to content

Commit

Permalink
Turn off continue-on-error in CI
Browse files Browse the repository at this point in the history
We want the workflow run to fail if any of the jobs fails.

The motivation for the current configuration is not clear to me, but I’m
guessing the idea was that the failure of a single job shouldn’t cancel
the others. Turning off fail-fast should do the same thing.

(Copied from ably-js commit ddef9f7.)
  • Loading branch information
lawrence-forooghian committed Apr 25, 2024
1 parent 2d4eaeb commit 1b3faa2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ on:
jobs:
check:
runs-on: ubuntu-latest
continue-on-error: true
strategy:
matrix:
fail-fast: false
ruby: [ '2.7', '3.0', '3.1' ]
protocol: [ 'json', 'msgpack' ]
type: [ 'unit', 'acceptance' ]
Expand Down

0 comments on commit 1b3faa2

Please sign in to comment.