Merge pull request #138 from ably/fix-history-pagination-test

Improve pagination history test
ably · Apr 20, 2018 · 07aabcf · 07aabcf
2 parents 8a7fece + eb729e1
commit 07aabcf
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/spec/acceptance/rest/channel_spec.rb b/spec/acceptance/rest/channel_spec.rb
@@ -343,7 +343,13 @@
 
         # Page 3
         expect(page_3.items.size).to eql(1)
-        expect(page_3).to be_last
+        # This test should be deterministic but it's not.
+        # Sometimes the backend, to avoid too much work, returns a `next` link that contains empty reults.
+        if page_3.next
+          expect(page_3.next.items.length).to eql(0)
+        else
+          expect(page_3).to be_last
+        end
       end
 
       context 'direction' do