Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3862] Add sync support using unasync #537

Merged
merged 52 commits into from
Oct 19, 2023
Merged

[SDK-3862] Add sync support using unasync #537

merged 52 commits into from
Oct 19, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Oct 4, 2023 •
edited
Loading

  • Converted async code into sync code.
  • Generated rest-specific tests for the generated source code.
  • Use sync methods by updating import from ably package to ably.sync package ( This is to avoid naming conflicts and better verbosity + readability)
   from ably.sync import AblyRestSync
   or 
   from ably.sync import AblyRestSync as AblyRest

@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 4, 2023 15:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 4, 2023 15:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 4, 2023 17:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 4, 2023 18:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 06:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 07:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 09:21 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-using-unasync branch from f447877 to d83597f Compare October 5, 2023 09:23
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 09:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 09:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 09:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 5, 2023 10:42 Inactive
@sacOO7 sacOO7 requested a review from owenpearson October 5, 2023 10:42
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 6, 2023 11:53 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review October 6, 2023 11:55
@sacOO7 sacOO7 requested a review from ttypic October 6, 2023 11:57
ttypic
ttypic approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

owenpearson
owenpearson requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 🙂 Just a few things I think we should change before release:

.github/workflows/check.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
UPDATING.md Outdated Show resolved Hide resolved
UPDATING.md Show resolved Hide resolved
UPDATING.md Outdated Show resolved Hide resolved
unasync.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 13:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 13:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 13:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 14:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 14:11 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 14:14 Inactive
@sacOO7 sacOO7 requested a review from owenpearson October 9, 2023 14:15
@github-actions github-actions bot temporarily deployed to staging/pull/537/features October 9, 2023 15:14 Inactive
@owenpearson owenpearson merged commit 0de24e4 into main Oct 19, 2023
5 checks passed
@owenpearson owenpearson deleted the feature/add-sync-using-unasync branch October 19, 2023 16:32
@sacOO7 sacOO7 mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@ttypic ttypic ttypic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: synchronous API variant
3 participants
@sacOO7 @ttypic @owenpearson