Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3862] Add sync support using decorator #535

Closed
wants to merge 22 commits into from
Closed

[SDK-3862] Add sync support using decorator #535

wants to merge 22 commits into from

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Sep 29, 2023 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 15:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 15:10 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from a8522d0 to 7ed3ca9 Compare September 29, 2023 15:32
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 15:33 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 7ed3ca9 to c6d99a4 Compare September 29, 2023 15:34
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 15:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 15:47 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from f81bae4 to 33c940b Compare September 29, 2023 15:50
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 15:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 16:08 Inactive
@sacOO7 sacOO7 changed the title Feature/add sync decorater [SDK-3862] Add sync support Sep 29, 2023
@sacOO7 sacOO7 changed the title [SDK-3862] Add sync support [SDK-3862] Add sync support using decorator Sep 29, 2023
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 16:57 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 5adad3e to 1ccb72d Compare September 29, 2023 16:58
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 16:58 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Sep 29, 2023 •
edited
Loading

TODO

  • 1. Add individual test for optional_sync
  • 2. Add tests for sync rest api

@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 17:30 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 603e9ea to e5fcea3 Compare September 29, 2023 17:31
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 17:32 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from e5fcea3 to 55a773f Compare September 29, 2023 17:34
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from f55fff8 to 7f87a51 Compare September 29, 2023 19:55
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 19:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 20:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 20:45 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 3df6611 to 0172888 Compare September 29, 2023 20:45
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 20:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 20:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 21:34 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 430dcc4 to 5e05827 Compare September 29, 2023 21:35
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 21:36 Inactive
@sacOO7 sacOO7 requested a review from owenpearson September 29, 2023 21:36
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 5e05827 to 99bf72f Compare September 29, 2023 21:37
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 21:38 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 99bf72f to 7edff52 Compare September 29, 2023 21:44
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 21:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 29, 2023 22:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 30, 2023 07:09 Inactive
@sacOO7 sacOO7 force-pushed the feature/add-sync-decorater branch from 5665509 to 6087436 Compare September 30, 2023 07:18
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 30, 2023 07:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/535/features September 30, 2023 07:24 Inactive
@sacOO7 sacOO7 closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson Awaiting requested review from owenpearson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: synchronous API variant
1 participant
@sacOO7