Fixed eventloop closing deorator for rest sync

ably · Oct 3, 2023 · 5cf52ce · 5cf52ce
1 parent 29e98fc
commit 5cf52ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/ably/executer/decorator.py b/ably/executer/decorator.py
@@ -114,14 +114,11 @@ def close_app_eventloop(fn):
 
     @functools.wraps(fn)
     def wrapper(self, *args, **kwargs):
-
-        app_loop: events = self.app_loop
-
+        # todo - this decorator will change if eventloop is also active for async operations
         if not self.sync_enabled:
-            app_loop.close()
             return fn(self, *args, **kwargs)
 
-        # Block the caller till result is returned
+        app_loop: events = self.app_loop
         future = asyncio.run_coroutine_threadsafe(fn(self, *args, **kwargs), app_loop.loop)
         result = future.result()
         app_loop.close()

diff --git a/ably/executer/eventloop.py b/ably/executer/eventloop.py
@@ -10,7 +10,7 @@ class AppEventLoop:
     __thread: threading
     __is_active: bool
 
-    def __init__(self, loop=None, thread=None):
+    def __init__(self, loop, thread=None):
         if not loop.is_running:
             raise Exception("Provided eventloop must be in running state")
         self.__loop = loop