-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add release information for 2.6.0 #1936
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request include updates to the versioning of the package and related files. The Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
9-9
: Document experimental featuresThe experimental attributes for Message type supporting edits and deletes should be clearly documented with:
- A warning that these are experimental features subject to change
- Examples of usage
- Any limitations or known issues
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (3)
CHANGELOG.md
(1 hunks)package.json
(1 hunks)src/platform/react-hooks/src/AblyReactHooks.ts
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- src/platform/react-hooks/src/AblyReactHooks.ts
- package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
db140f9
to
8a3552d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Update the date and can merge
This change adds the README and other updates for 2.6.0.
Summary by CodeRabbit
New Features
LEAVE
event only if a member was previously present.Message
type for edits and deletes.Bug Fixes
ably-js
repository.Version Updates
2.5.0
to2.6.0
across relevant files.