Upgrade Prettier and run on all supported files #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve removed the trailingComma config, since it’s "all" by default as of version 3.0.0 [1]. [1] https://prettier.io/blog/2023/07/05/3.0.0.html#change-the-default-value-for-trailingcomma-to-all-11479httpsgithubcomprettierprettierpull11479-by-fiskerhttpsgithubcomfisker-13143httpsgithubcomprettierprettierpull13143-by-sosukesuzukihttpsgithubcomsosukesuzuki
It’s a bit annoying having to keep adding new files to the list each time we add a new directory or something. And there are some things that we should have been automatically formatting but weren’t, e.g. our YAML files. I’ve removed the --ignore-path arguments since the Prettier documentation [1] says that > By default, Prettier looks for ./.gitignore and ./.prettierignore. [1] https://prettier.io/docs/en/cli#--ignore-path
It’s already in .gitignore and hence ignored by Prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Context: I was making some changes to the GitHub workflow files elsewhere and noticed that Git was showing me trailing whitespace, meaning that these files weren’t being automatically formatted. So thought I’d fix that.)
See commit messages for more details.