[WIP, ECO-15] Add interception proxy to unified test suite #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
lawrence-forooghian
force-pushed
the
ECO-15-unified-test-suite-with-interception-proxy
branch
from
a8b980e to
09907d2
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
lawrence-forooghian
force-pushed
the
ECO-15-unified-test-suite-with-interception-proxy
branch
from
09907d2 to
0288761
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
lawrence-forooghian
force-pushed
the
unified-test-suite
branch
from
dc4ddc3 to
8d162a0
Compare
For upcoming interception proxy. TODO: once I’ve got rid of the subsequent commit with the old Python code, put this into the later commit instead
Implemented entirely as an mitmproxy addon. Abandoned because it didn’t give me sufficient control over WebSocket connection lifetimes.
This reverts commit 7ad3145. (I just want to keep it in the Git history for now, in case for some reason it’s useful to return to.)
lawrence-forooghian
changed the base branch from
unified-test-suite
to
ECO-4787-prototype-interception-proxy
lawrence-forooghian
force-pushed
the
ECO-15-unified-test-suite-with-interception-proxy
branch
from
ec9b138 to
8a36f47
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
lawrence-forooghian
force-pushed
the
ECO-15-unified-test-suite-with-interception-proxy
branch
from
8a36f47 to
4e613dc
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
lawrence-forooghian
force-pushed
the
ECO-15-unified-test-suite-with-interception-proxy
branch
from
d1d6a96 to
8f7002b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1818/bundle-report
- start-interception-proxy adapted from https://github.com/ably/sdk-test-proxy at 82e93a7 Some TODOs which aren’t really important right now because this is just a prototype: - TODO fix type checking for interception proxy — `npm run build` does it properly, but tried to reproduce the way we do it for modulereport and it didn’t work - TODO fix linting for interception proxy — doesn’t seem to be catching lint errors - TODO linting / type checking etc for Python code Also: > Add test:playwright:open-browser script > > Lets you open a headed browser which is configured to use the > interception proxy. Useful for local debugging of browser tests.
lawrence-forooghian
force-pushed
the
ECO-4787-prototype-interception-proxy
branch
from
cf1a729 to
656f5b7
Compare
TODO incorporate into upstream
it was getting unwieldly and would have been hard to add a further method
TODO incorporate
This also introduces the interception proxy ability to inject messages. done the interception part; need to implement injection in the proxy now. TODO document the injectMessage API; it’s currently in my notes.
TODO integrate into upstream
lawrence-forooghian
force-pushed
the
ECO-15-unified-test-suite-with-interception-proxy
branch
from
8f7002b to
0368c70
Compare
lawrence-forooghian
force-pushed
the
ECO-4787-prototype-interception-proxy
branch
from
656f5b7 to
14d00c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title of this PR is misleading; this is currently holding some changes that I’ll integrate back into the prototype branch.