[WIP] Eco 4821 turn shared helper into object #1785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves ECO-4786.
lawrence-forooghian
changed the title
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
39fe05f to
c483622
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
c483622 to
394dba0
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
394dba0 to
69610ec
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
the aim here is to make it easier to drop a `helper` object inside the test (there are still references to `helper` outside the test though, so there’s work to do; but I think I’ll find most except for loadTestData by looking for named `function`s after; and there are some as a var too) in a couple of places i've replaced a var with such a function (i.e. one that currently refers directly to the globally-scoped helper but which we'll change shortly)
It isn’t intended be called as a constructor.
TODO figure out what should be class method; at the moment everything is instance except for the ones that have a .skip because that wasn't implementable for an instance method, and also because these clearly aren’t going to be called at a per-test level. But there may well be other stuff (e.g. stuff that's used at a non-test level, or it might just be that the instance doesn't always have a test)
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
69610ec to
80e352b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
there's no private api use, these are uncontroversial
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
1165d92 to
87e0d09
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
87e0d09 to
3140aad
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
3140aad to
0ad883c
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
0ad883c to
946c89e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
946c89e to
28c1b7b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1785/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-turn-shared-helper-into-object
branch
from
28c1b7b to
a987470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.