[WIP, ECO-4821] Gather further private API usage info #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
changed the base branch from
main
to
ECO-4786-document-private-API-usage
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
It isn’t intended be called as a constructor.
TODO figure out what should be class method; at the moment everything is instance except for the ones that have a .skip because that wasn't implementable for an instance method, and also because these clearly aren’t going to be called at a per-test level. But there may well be other stuff (e.g. stuff that's used at a non-test level, or it might just be that the instance doesn't always have a test)
there's no private api use, these are uncontroversial
lawrence-forooghian
force-pushed
the
ECO-4821-gather-further-private-API-usage-info
branch
from
cc2b8a8 to
1207f4b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-gather-further-private-API-usage-info
branch
from
1207f4b to
81524a7
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-gather-further-private-API-usage-info
branch
from
81524a7 to
c2f8591
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
lawrence-forooghian
force-pushed
the
ECO-4821-gather-further-private-API-usage-info
branch
from
c2f8591 to
9986dc4
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1784/bundle-report
|
Here's the data gathered at commit 9986dc4 from this job: private-api-usage-9986dc4.json. We’ll do something with it in ECO-4834. |
TODO incorporate into 3a10b09. Context: when, in a later commit, I attempted to modify `this.helper` inside an `it` to add to its helperStack (for e.g. the tests generated by testOnAllTransports), it seemed to have some weird global effect; i.e. the helper then became used by other tests. - in test, `this` is `Context { _runnable: Test, test: Test }` - in root hook, `this` is `Context { currentTest: Test, _runnable: Hook }` Setting it on the `Test` object instead of on `this` seems to fix it.
Preparation for logging private API usage.
For ECO-4821 (getting better information on private API usage, in the context of reusing this test suite as a unified test suite). (Note I haven't been very consistent with how many times per test I record the usage of a given private API; it’s not a stat I’m particularly interested in here. But for the most part I’m doing it at the point of each invocation of the private API.)
lawrence-forooghian
force-pushed
the
ECO-4821-gather-further-private-API-usage-info
branch
from
9986dc4 to
d551ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #1756. Gathering data on private API usage in tests for ECO-4821, so that we can see what work needs to be done to reuse them as the unified test suite.