Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REA-1702] feat: web push #1775

Merged
merged 7 commits into from
Jul 2, 2024
Merged

[REA-1702] feat: web push #1775

merged 7 commits into from
Jul 2, 2024

Conversation

owenpearson
Copy link
Member

  • adds a plugin which enables clients to be activated for receipt of push notifications.
  • adds support for w3c push transport to web clients.
  • adds push channel transport for testing push activation on all platforms.

@owenpearson owenpearson requested review from VeskeR and ttypic May 22, 2024 08:42
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features May 22, 2024 08:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report May 22, 2024 08:43 Inactive
@owenpearson owenpearson force-pushed the push-activation-v2 branch from df841d6 to 9175832 Compare May 22, 2024 08:49
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features May 22, 2024 08:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report May 22, 2024 08:49 Inactive
ttypic
ttypic requested changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! very consistent to what we have in java and cocoa, added couple of small comments

src/common/lib/client/push.ts Show resolved Hide resolved
src/common/lib/client/pushchannel.ts Outdated Show resolved Hide resolved
src/plugins/push/pushactivation.ts Outdated Show resolved Hide resolved
src/plugins/push/pushactivation.ts Outdated Show resolved Hide resolved
src/plugins/push/pushactivation.ts Outdated Show resolved Hide resolved
src/plugins/push/pushactivation.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 12, 2024 21:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 12, 2024 21:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 12, 2024 21:11 Inactive
@jamienewcomb jamienewcomb requested a review from ttypic June 13, 2024 09:03
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 13, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 13, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 13, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 13, 2024 21:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 13, 2024 21:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 13, 2024 21:02 Inactive
VeskeR
VeskeR requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@VeskeR VeskeR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a wall of comments but mostly they are structural suggestions.

Couple of things that I couldn't attach to code lines:

  1. Should we add new Push plugin to scripts/moduleReport.ts pluginNames list? I imagine we would need to update getBundleInfo in there, as currently it always imports from './build/modular/index.mjs'.
  2. Per RSH7 both RestChannel and RealtimeChannel should have push object. Why did we add push only to RestChannel here?

P.S. sorry for the amount of comments 😬 I wonder if we could've done it in separate PRs for web push integration branch.

push.d.ts Outdated Show resolved Hide resolved
test/browser/push.test.js Show resolved Hide resolved
src/common/lib/client/push.ts Outdated Show resolved Hide resolved
src/common/lib/client/push.ts Outdated Show resolved Hide resolved
src/common/lib/client/push.ts Outdated Show resolved Hide resolved
test/browser/push.test.js Outdated Show resolved Hide resolved
test/rest/push.test.js Outdated Show resolved Hide resolved
src/platform/web/lib/transport/push.ts Outdated Show resolved Hide resolved
test/support/push_channel_transport.js Outdated Show resolved Hide resolved
test/support/push_channel_transport.js Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 17, 2024 15:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 17, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 17, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 17, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 17, 2024 17:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 24, 2024 13:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 24, 2024 13:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 24, 2024 13:45 Inactive
@owenpearson owenpearson mentioned this pull request Jun 24, 2024
Merged
4 tasks
@owenpearson owenpearson requested a review from VeskeR June 24, 2024 14:19
VeskeR
VeskeR requested changes Jun 24, 2024
View reviewed changes
ably.d.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1775/features June 25, 2024 08:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/typedoc June 25, 2024 08:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1775/bundle-report June 25, 2024 08:36 Inactive
@owenpearson owenpearson requested a review from VeskeR June 25, 2024 08:37
VeskeR
VeskeR approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ttypic
ttypic approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenpearson owenpearson merged commit a6e5f23 into main Jul 2, 2024
12 checks passed
@owenpearson owenpearson deleted the push-activation-v2 branch July 2, 2024 17:19
VeskeR added a commit that referenced this pull request Oct 1, 2024
@VeskeR
Expose LiveObjects as a plugin
57cbb82 
Base code, tests and build setup for new LiveObjects plugin. Adds a new
`.liveObjects` property for RealtimeChannel.

Plugin setup is based on Web Push plugin PR [1], and CDN setup for Push
plugin PR [2].

Resolves DTP-947

[1] #1775
[2] #1861
@VeskeR VeskeR mentioned this pull request Oct 1, 2024
Merged
VeskeR added a commit that referenced this pull request Oct 1, 2024
@VeskeR
Expose LiveObjects as a plugin
f0bb1ba 
Base code, tests and build setup for new LiveObjects plugin. Adds a new
`.liveObjects` property for RealtimeChannel.

Plugin setup is based on Web Push plugin PR [1], and CDN setup for Push
plugin PR [2].

Resolves DTP-947

[1] #1775
[2] #1861
VeskeR added a commit that referenced this pull request Oct 1, 2024
@VeskeR
Expose LiveObjects as a plugin
f3490a0 
Base code, tests and build setup for new LiveObjects plugin. Adds a new
`.liveObjects` property for RealtimeChannel.

Plugin setup is based on Web Push plugin PR [1], and CDN setup for Push
plugin PR [2].

Resolves DTP-947

[1] #1775
[2] #1861
VeskeR added a commit that referenced this pull request Oct 1, 2024
@VeskeR
Expose LiveObjects as a plugin
5d66652 
Base code, tests and build setup for new LiveObjects plugin. Adds a new
`.liveObjects` property for RealtimeChannel.

Plugin setup is based on Web Push plugin PR [1], and CDN setup for Push
plugin PR [2].

Resolves DTP-947

[1] #1775
[2] #1861
VeskeR added a commit that referenced this pull request Oct 2, 2024
@VeskeR
Expose LiveObjects as a plugin
fbf46a7 
Base code, tests and build setup for new LiveObjects plugin. Adds a new
`.liveObjects` property for RealtimeChannel.

Plugin setup is based on Web Push plugin PR [1], and CDN setup for Push
plugin PR [2].

Resolves DTP-947

[1] #1775
[2] #1861
VeskeR added a commit that referenced this pull request Oct 2, 2024
@VeskeR
Expose LiveObjects as a plugin
d9d6408 
Base code, tests and build setup for new LiveObjects plugin. Adds a new
`.liveObjects` property for RealtimeChannel.

Plugin setup is based on Web Push plugin PR [1], and CDN setup for Push
plugin PR [2].

Resolves DTP-947

[1] #1775
[2] #1861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers left review comments

@ttypic ttypic ttypic approved these changes

@VeskeR VeskeR VeskeR approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owenpearson @paddybyers @VeskeR @ttypic