Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types/capability: allow wildcard capability when presented in object form, add privileged-headers capability #1765

Merged
merged 2 commits into from
May 17, 2024

Conversation

AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented May 17, 2024

At the moment, it's not possible (according to TypeScript) to specify a capability as {"resource": ["*"]} using the map-form - which is still valid. This change also allows the explicit specification of a wildcard.

…form

At the moment, it's not possible to specify a capability as `{"resource": ["*"]}` - which is still
valid. This change also allows the explicit specification of a wildcard.

format: quotes
@github-actions github-actions bot temporarily deployed to staging/pull/1765/features May 17, 2024 08:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1765/bundle-report May 17, 2024 08:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1765/typedoc May 17, 2024 08:29 Inactive
@AndyTWF AndyTWF requested a review from VeskeR May 17, 2024 08:29
ably.d.ts Show resolved Hide resolved
@VeskeR VeskeR changed the title types/capability: allow wildcard capability when presented in object form types/capability: allow wildcard capability when presented in object form, add privileged-headers capability May 17, 2024
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyTWF AndyTWF merged commit bc4f3ac into main May 17, 2024
12 checks passed
@AndyTWF AndyTWF deleted the wildcard-capability branch May 17, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants