Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4130] Fix ConnectionManager reusing error object stored in errorReason #1760

Merged
merged 1 commit into from
May 14, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented May 14, 2024

Resolves #1573

This helps with troubleshooting issues like #1753, #1565, #1759

@VeskeR VeskeR requested a review from owenpearson May 14, 2024 05:52
@VeskeR VeskeR changed the title Fix ConnectionManager reusing error object stored in errorReason [ECO-1805] Fix ConnectionManager reusing error object stored in errorReason May 14, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/1760/features May 14, 2024 05:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1760/bundle-report May 14, 2024 05:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1760/typedoc May 14, 2024 05:53 Inactive
@VeskeR VeskeR changed the title [ECO-1805] Fix ConnectionManager reusing error object stored in errorReason [ECO-4130] Fix ConnectionManager reusing error object stored in errorReason May 14, 2024
@VeskeR VeskeR force-pushed the 1573/fix-reused-error-reasons branch from c9c8659 to eda9c41 Compare May 14, 2024 05:54
@github-actions github-actions bot temporarily deployed to staging/pull/1760/features May 14, 2024 05:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1760/bundle-report May 14, 2024 05:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1760/typedoc May 14, 2024 05:55 Inactive
@VeskeR VeskeR merged commit c6e18fe into main May 14, 2024
12 checks passed
@VeskeR VeskeR deleted the 1573/fix-reused-error-reasons branch May 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Re-used errorReasons have misleading stack traces
2 participants