Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docstring for release method #1752

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

ttypic
Copy link
Collaborator

@ttypic ttypic commented Apr 25, 2024

Originally, release() cleaned up listeners according to the spec. However, the spec changed at some point, and the ably-js implementation changed, but the docstring hadn't been updated.

@ttypic ttypic merged commit dba5fa0 into main Apr 25, 2024
8 of 12 checks passed
@ttypic ttypic deleted the fix-wrong-docstring-for-release branch April 25, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants