Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test app manager: respect ablyGlobals settings re port/tls #1746

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

SimonWoolf
Copy link
Member

allows tests to run against a local realtime with ABLY_ENV=local ABLY_PORT=8081 ABLY_USE_TLS=false
(which used to work, I think it was broken by the change to get rid of the use of self-signed certs for local dev)

Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonWoolf SimonWoolf merged commit c5bc4dc into main Apr 18, 2024
8 of 12 checks passed
@SimonWoolf SimonWoolf deleted the test-app-respect-globals branch April 18, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants