-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update Ably JS in Chrome extension #1743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1743/bundle-report
April 17, 2024 11:36
Inactive
ttypic
commented
Apr 17, 2024
owenpearson
requested changes
Apr 17, 2024
github-actions
bot
temporarily deployed
to
staging/pull/1743/bundle-report
April 17, 2024 15:27
Inactive
ttypic
force-pushed
the
ECO-4749/improve-chrome-manifest-section
branch
from
April 17, 2024 15:29
b58689a
to
fc1f6a1
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1743/bundle-report
April 17, 2024 15:30
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1743/bundle-report
April 17, 2024 20:21
Inactive
Co-authored-by: Owen Pearson <[email protected]>
ttypic
force-pushed
the
ECO-4749/improve-chrome-manifest-section
branch
from
April 17, 2024 20:24
1d2d4a8
to
fb52cd4
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1743/bundle-report
April 17, 2024 20:24
Inactive
VeskeR
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor wording change suggestion
Co-authored-by: Andrew Bulat <[email protected]>
owenpearson
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1739
Jira issue ECO-4749