Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Ably JS in Chrome extension #1743

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

ttypic
Copy link
Collaborator

@ttypic ttypic commented Apr 17, 2024

Resolves #1739
Jira issue ECO-4749

@github-actions github-actions bot temporarily deployed to staging/pull/1743/features April 17, 2024 11:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/typedoc April 17, 2024 11:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/bundle-report April 17, 2024 11:36 Inactive
@ttypic ttypic requested review from VeskeR and owenpearson April 17, 2024 11:41
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1743/features April 17, 2024 15:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/bundle-report April 17, 2024 15:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/typedoc April 17, 2024 15:27 Inactive
@ttypic ttypic force-pushed the ECO-4749/improve-chrome-manifest-section branch from b58689a to fc1f6a1 Compare April 17, 2024 15:29
@github-actions github-actions bot temporarily deployed to staging/pull/1743/features April 17, 2024 15:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/typedoc April 17, 2024 15:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/bundle-report April 17, 2024 15:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/features April 17, 2024 20:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/bundle-report April 17, 2024 20:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/typedoc April 17, 2024 20:21 Inactive
@ttypic ttypic force-pushed the ECO-4749/improve-chrome-manifest-section branch from 1d2d4a8 to fb52cd4 Compare April 17, 2024 20:24
@github-actions github-actions bot temporarily deployed to staging/pull/1743/features April 17, 2024 20:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/typedoc April 17, 2024 20:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1743/bundle-report April 17, 2024 20:24 Inactive
@ttypic ttypic requested a review from owenpearson April 17, 2024 20:27
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor wording change suggestion

README.md Outdated Show resolved Hide resolved
@ttypic ttypic merged commit 4397c82 into main Apr 29, 2024
11 of 12 checks passed
@ttypic ttypic deleted the ECO-4749/improve-chrome-manifest-section branch April 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update docs about using Ably in Chrome Extension
3 participants