-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4721] Fix rest fallback behavior #1721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1721/bundle-report
April 5, 2024 10:56
Inactive
VeskeR
force-pushed
the
1717/fix-rest-fallback-behavior
branch
from
April 5, 2024 10:58
76a77af
to
c1f119c
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1721/bundle-report
April 5, 2024 10:58
Inactive
It should be 10 seconds according to TO3l4
VeskeR
force-pushed
the
1717/fix-rest-fallback-behavior
branch
from
April 17, 2024 11:54
c1f119c
to
d722520
Compare
Add missing `httpMaxRetryDuration` value to Defaults.TIMEOUTS Resolves #1717
github-actions
bot
temporarily deployed
to
staging/pull/1721/bundle-report
April 17, 2024 11:55
Inactive
VeskeR
force-pushed
the
1717/fix-rest-fallback-behavior
branch
from
April 17, 2024 11:55
d722520
to
be6a9ac
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1721/bundle-report
April 17, 2024 11:56
Inactive
VeskeR
force-pushed
the
1717/fix-rest-fallback-behavior
branch
from
April 17, 2024 12:09
be6a9ac
to
5419ef3
Compare
lawrence-forooghian
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1717
Fixes incorrect default value for
httpRequestTimeout
client option. It should be 10 seconds according to TO3l4.Implements missing
httpMaxRetryDuration
functionality and adds tests for it per TO3l6.