build(node): mark ws as external module #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1716/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1716/bundle-report
VeskeR
reviewed
Mar 27, 2024
owenpearson
force-pushed
the
node-ws-external
branch
from
00079a7 to
a6aabed
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1716/bundle-report
VeskeR
requested changes
Mar 27, 2024
owenpearson
force-pushed
the
node-ws-external
branch
from
a6aabed to
791929b
Compare
|
Merging this PR on Owen's behalf, as he is out of the office, and we want to release this fix as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue with realtime connections using the bun runtime
(also marks
gotas external just so we aren't pinned to a specific version)