Fix stray second arg to modular constructor #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed this in e8c3012.
owenpearson
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
LGTM 👍
Also, since this test suite is an es module istm we should easily be able to enable type checking for development here. Might be different for other editors but in my neovim i can get a type warning for this issue by running cp modular.d.ts build/modular/index.d.ts and adding a // @ts-check comment to the top of modular.test.js.
|
Thanks @owenpearson, created #1703 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this in e8c3012.