[ECO-4128] Fix race condition in authbase0 test case
#1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1579/features
github-actions
bot
temporarily deployed
to
staging/pull/1579/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1579/typedoc
VeskeR
changed the title
authbase0 test caseauthbase0 test case
VeskeR
changed the title
authbase0 test caseauthbase0 test case
There was an intentional change in realtime code regarding populating `TokenDetails.issued` field based on `timestamp` field provided by the request [1]. Starting from this change, provided `timestamp` field can now used to set the `TokenDetails.issued` field. It is done to "Make it easier to construct reliable tests for eg token expiry and revocation, by controlling the timestamp we pass in." This does, however, mean that in order for time-sensitive tests to work properly and avoid race conditions, we need to always either set `queryTime: true` or set `queryTime: false`. We need to ensure that we use the same value everywhere, so that the realtime code returns `TokenDetails.issued` based on consistent data when we need to check it. This commit does that for the tests where we use `TokenDetails.issued` in assertions. Resolves #1578 [1] ably/realtime@359930d
VeskeR
force-pushed
the
1578-fix-authbase0
branch
from
5190a87 to
7e71eac
Compare
lawrence-forooghian
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1578