fix: use 'ably' as import path from react-hooks #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1509/features
owenpearson
force-pushed
the
fix-react-hooks-ably-import
branch
from
bd66801 to
77b50ea
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1509/features
github-actions
bot
temporarily deployed
to
staging/pull/1509/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1509/bundle-report
The import paths here only worked before by accident - tsc would compile then to `from '../../../ably'` which in most cases would resolve to `node_modules/ably` however in certain environments (pnpm) this would not be the case and therefore the types would not be imported correctly. I've updated the tsconfig compilerOptions.paths field so that these are resolved correctly for development, and when consumed as a library these will just import directly from the 'ably' module.
owenpearson
force-pushed
the
fix-react-hooks-ably-import
branch
from
77b50ea to
7af5a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1495
The import paths here only worked before by accident - tsc would compile then to
from '../../../ably'which in most cases would resolve tonode_modules/ablyhowever in certain environments (pnpm) this would not be the case and therefore the types would not be imported correctly. I've updated the tsconfig compilerOptions.paths field so that these are resolved correctly for development, and when consumed as a library these will just import directly from the 'ably' module.