Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'derived' options in 'useChannel' hook #1501

Merged
merged 9 commits into from
Nov 16, 2023

Conversation

rustworthy
Copy link
Contributor

  • enabling 'derived' options to 'useChannel' hook;
  • updating 'fake' ably to mimic this behavior;
  • adding tests and example usage to 'sample-app'

@rustworthy rustworthy changed the title Enable 'derived' options to 'useChannel' hook Enable 'derived' options in 'useChannel' hook Nov 13, 2023
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rustworthy, thanks for submitting this! I've had a play around with it locally and it works great, really appreciate that you updated the tests too 🙂

I have one minor comment (below) and I do think we ought something to react.md so that this is discoverable to others. I'm happy to take care of both if you'd prefer, just let me know

package.json Show resolved Hide resolved
@rustworthy
Copy link
Contributor Author

Hey @rustworthy, thanks for submitting this! I've had a play around with it locally and it works great, really appreciate that you updated the tests too 🙂

I have one minor comment (below) and I do think we ought something to react.md so that this is discoverable to others. I'm happy to take care of both if you'd prefer, just let me know

Hey @owenpearson!

My pleasure. Relying on the library (and enjoying working with it) on a project with a notification framework where Kafka is connected to Ably with a sink connector and a lot of meta information is carried in the messages' headers. At the application level (Next.js deployed on Vercel) we are using filter expressions to only get those messages that are of interest to the current user. This is just for the context :)

Added example usage to the docs.

Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Really interesting to hear about your use case and I'm glad it's working well so far! thanks again for the contribution, we'll release this very soon 🙂

@owenpearson owenpearson merged commit 3dbd400 into ably:main Nov 16, 2023
5 of 11 checks passed
@owenpearson
Copy link
Member

Hey @rustworthy just to let you know this is now available in version 1.2.48 🙂

@rustworthy
Copy link
Contributor Author

Hey @rustworthy just to let you know this is now available in version 1.2.48 🙂

Hey @owenpearson
Supercool:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants