fix: don't compare agent channel param when determining whether channel options require reattach
#1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1478/features
github-actions
bot
temporarily deployed
to
staging/pull/1478/bundle-report
owenpearson
force-pushed
the
react-channel-options-fix
branch
from
1651f8d to
ad264d9
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1478/features
github-actions
bot
temporarily deployed
to
staging/pull/1478/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1478/typedoc
…nnel options require reattach
owenpearson
force-pushed
the
react-channel-options-fix
branch
from
ad264d9 to
49b4b6d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1478/features
github-actions
bot
temporarily deployed
to
staging/pull/1478/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1478/typedoc
owenpearson
force-pushed
the
react-channel-options-fix
branch
from
49b4b6d to
2d839b4
Compare
lawrence-forooghian
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1477
Excludes the agent param is excluded when checking whether channel options provided to
Channels.getwill require re-attachment