Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3733] Make realtime transports tree-shakable #1432

Merged
merged 13 commits into from
Nov 21, 2023
Merged

[SDK-3733] Make realtime transports tree-shakable #1432

merged 13 commits into from
Nov 21, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

Note: This PR is based on top of #1429; please review that one first.

This exposes tree-shakable WebSocketTransport, XHRPolling, and XHRStreaming modules.

See commit messages for more details.

Resolves #1394.

@github-actions github-actions bot temporarily deployed to staging/pull/1432/features August 31, 2023 23:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report August 31, 2023 23:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc August 31, 2023 23:15 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from 7f19222 to ad4f6a3 Compare August 31, 2023 23:24
@github-actions github-actions bot temporarily deployed to staging/pull/1432/features August 31, 2023 23:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc August 31, 2023 23:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report August 31, 2023 23:26 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review September 1, 2023 01:22
@lawrence-forooghian lawrence-forooghian force-pushed the 1427-remove-static-PresenceMessage-in-tree-shakable-library branch from babb0f6 to f571734 Compare September 5, 2023 08:40
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from ad4f6a3 to 14424f1 Compare September 5, 2023 08:41
@github-actions github-actions bot temporarily deployed to staging/pull/1432/features September 5, 2023 08:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report September 5, 2023 08:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc September 5, 2023 08:42 Inactive
@lawrence-forooghian lawrence-forooghian mentioned this pull request Sep 14, 2023
Merged
@lawrence-forooghian lawrence-forooghian force-pushed the 1427-remove-static-PresenceMessage-in-tree-shakable-library branch from f571734 to 77dcc87 Compare September 14, 2023 12:53
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from 14424f1 to 1feb6e3 Compare September 14, 2023 12:54
@github-actions github-actions bot temporarily deployed to staging/pull/1432/features September 14, 2023 12:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc September 14, 2023 12:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report September 14, 2023 12:55 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from 1feb6e3 to 23c83d9 Compare October 26, 2023 14:33
@github-actions github-actions bot temporarily deployed to staging/pull/1432/features October 26, 2023 14:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc October 26, 2023 14:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report October 26, 2023 14:34 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1427-remove-static-PresenceMessage-in-tree-shakable-library branch from 77dcc87 to 594da2f Compare October 26, 2023 16:44
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from 23c83d9 to b66c87b Compare October 26, 2023 16:52
@github-actions github-actions bot temporarily deployed to staging/pull/1432/features October 26, 2023 16:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report October 26, 2023 16:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc October 26, 2023 16:54 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1427-remove-static-PresenceMessage-in-tree-shakable-library branch from 594da2f to 0af932a Compare October 26, 2023 17:23
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from 21d387c to d986ea2 Compare November 8, 2023 17:19
@github-actions github-actions bot temporarily deployed to staging/pull/1432/features November 8, 2023 17:19 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/bundle-report November 8, 2023 17:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1432/typedoc November 8, 2023 17:20 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review November 8, 2023 18:28
owenpearson
owenpearson requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks great, one comment about the modules api though:

src/common/lib/client/baserealtime.ts Show resolved Hide resolved
@lawrence-forooghian lawrence-forooghian force-pushed the 1427-remove-static-PresenceMessage-in-tree-shakable-library branch from 962a06d to 0e722b9 Compare November 14, 2023 18:50
@lawrence-forooghian
Properly type realtime instance in ConnectionManager
50a934a
@lawrence-forooghian
Fix type of IPlatform.Transports
b818c27
@lawrence-forooghian
Extract type of IPlatform.Transports
ebbb354 
Preparation for #1394 (making transports tree-shakable).
@lawrence-forooghian
Convert platform/**/lib/transport/index.ts to TypeScript
5d0a71c
@lawrence-forooghian
Fix inflection of TransportNames enum name
17fce55
@lawrence-forooghian
Use TransportName values when setting transports’ shortName
a0df5f5 
Preparation for #1394 (making transports tree-shakable).
@lawrence-forooghian
Decouple Platform.Transport’s transport order from implementations
8d4e477 
Preparation for #1394 (making transports tree-shakable).
@lawrence-forooghian
Fix connectionManager type in transport initialisers
4fe06fa
@lawrence-forooghian
Fix supportedTransports type
af25aa4 
Using the bare Record<string, ...> type implies that fetching from it
will return a value for any string key, which isn’t the case.
@lawrence-forooghian
Properly type client options in connectionmanager.ts
ead8662
@lawrence-forooghian
Tighten up type in places where transport name is used
f05de53
@lawrence-forooghian
Move supportedTransports storage into ConnectionManager instance
57c09f6 
Preparation for #1394 (making transports tree-shakable).
@lawrence-forooghian
Make transports tree-shakable
d7f9bd5 
We expose WebSocketTransport, XHRPolling, and XHRStreaming modules.

Resolves #1394.
@lawrence-forooghian lawrence-forooghian force-pushed the 1394-tree-shakable-transports branch from d986ea2 to d7f9bd5 Compare November 14, 2023 18:50
Base automatically changed from 1427-remove-static-PresenceMessage-in-tree-shakable-library to integration/v2 November 21, 2023 00:13
@lawrence-forooghian lawrence-forooghian merged commit 4c351cd into integration/v2 Nov 21, 2023
11 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 1394-tree-shakable-transports branch November 21, 2023 00:14
@lawrence-forooghian lawrence-forooghian mentioned this pull request Nov 21, 2023
Closed
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawrence-forooghian @owenpearson