Merge pull request #1694 from ably/fix-lint-warnings

Fix lint warnings

.eslintrc.js

@@ -44,6 +44,9 @@ module.exports = {
       extends: [
         'plugin:jsdoc/recommended',
       ],
+      rules: {
+        "jsdoc/check-tag-names": ["warn", { "definedTags": ["experimental"] }],
+      },
     },
   ],
   ignorePatterns: [

ably.d.ts

@@ -1164,7 +1164,6 @@ declare namespace Types {
      * Controls the log output of the library. This is a function to handle each line of log output. If you do not set this value, then `console.log` will be used.
      *
      * @deprecated This property is deprecated and will be removed in a future version. Use the {@link ClientOptions.logHandler} client option instead.
-     *
      * @param msg - The log message emitted by the library.
      */
     handler?: (msg: string) => void;
@@ -3101,14 +3100,13 @@ declare namespace Types {
      */
     get(name: string, channelOptions?: ChannelOptions): T;
     /**
+     * Creates a new {@link ChannelBase} or {@link RealtimeChannelBase} object, with the specified channel {@link DeriveOptions}
+     * and {@link ChannelOptions}, or returns the existing channel object.
+     *
      * @experimental This is a preview feature and may change in a future non-major release.
      * This experimental method allows you to create custom realtime data feeds by selectively subscribing
      * to receive only part of the data from the channel.
      * See the [announcement post](https://pages.ably.com/subscription-filters-preview) for more information.
-     *
-     * Creates a new {@link ChannelBase} or {@link RealtimeChannelBase} object, with the specified channel {@link DeriveOptions}
-     * and {@link ChannelOptions}, or returns the existing channel object.
-     *
      * @param name - The channel name.
      * @param deriveOptions - A {@link DeriveOptions} object.
      * @param channelOptions - A {@link ChannelOptions} object.

src/platform/react-hooks/sample-app/src/script.tsx

@@ -7,7 +7,12 @@ import * as Ably from 'ably';
 import App from './App.js';
 import { AblyProvider } from '../../src/index.js';
 
-const container = document.getElementById('root')!;
+const rootId = 'root';
+const container = document.getElementById(rootId);
+
+if (!container) {
+  throw new Error(`No element found with id #${rootId} found`);
+}
 
 function generateRandomId() {
   return Math.random().toString(36).substr(2, 9);