Skip to content

Commit

Permalink
Turn off continue-on-error for browser jobs
Browse files Browse the repository at this point in the history
I _think_ this is preventing us from receiving email notifications when
one of the browser jobs fails.

The motivation for the current configuration is not clear to me, but I’m
guessing the idea was that the failure of a single browser test run
shouldn’t cancel the others. Turning off fail-fast should do the same
thing.
  • Loading branch information
lawrence-forooghian committed Nov 1, 2023
1 parent e3e6781 commit ddef9f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test-browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
jobs:
test-browser:
runs-on: ubuntu-20.04
continue-on-error: true
strategy:
fail-fast: false
matrix:
browser: [chromium, firefox, webkit]
steps:
Expand Down

0 comments on commit ddef9f7

Please sign in to comment.