Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared pref storage #986

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Fix shared pref storage #986

merged 4 commits into from
Feb 5, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Feb 5, 2024

@sacOO7 sacOO7 self-assigned this Feb 5, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/986/features February 5, 2024 08:10 Inactive
@sacOO7 sacOO7 requested review from ttypic and AndyTWF February 5, 2024 08:10
@github-actions github-actions bot temporarily deployed to staging/pull/986/features February 5, 2024 08:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/986/javadoc February 5, 2024 08:14 Inactive
AndyTWF
AndyTWF reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@AndyTWF AndyTWF left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one test failing in android

@github-actions github-actions bot temporarily deployed to staging/pull/986/features February 5, 2024 11:15 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/986/javadoc February 5, 2024 11:16 Inactive
@sacOO7 sacOO7 force-pushed the fix/clear_shared_pref_storage branch from 6fc8ea9 to 379081c Compare February 5, 2024 11:30
@sacOO7 sacOO7 requested a review from AndyTWF February 5, 2024 12:03
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Feb 5, 2024

Looks good - just one test failing in android

Fixed 👍

ttypic
ttypic approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sacOO7 sacOO7 merged commit accf93b into main Feb 5, 2024
9 checks passed
@sacOO7 sacOO7 deleted the fix/clear_shared_pref_storage branch February 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@AndyTWF AndyTWF AndyTWF approved these changes

Assignees

@sacOO7 sacOO7

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalDevice reset will cause ClassCastException
3 participants
@sacOO7 @AndyTWF @ttypic