Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection serial tests #984

Merged
merged 25 commits into from
Feb 6, 2024
Merged

Connection serial tests #984

merged 25 commits into from
Feb 6, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Dec 20, 2023 •
edited
Loading

  • Fixed failing tests for no-connection-serial PR

@github-actions github-actions bot temporarily deployed to staging/pull/984/features December 20, 2023 13:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc December 20, 2023 13:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 8, 2024 13:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 8, 2024 13:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 23, 2024 07:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 23, 2024 07:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 23, 2024 13:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 23, 2024 13:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 24, 2024 12:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 24, 2024 12:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 25, 2024 12:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 25, 2024 12:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 26, 2024 05:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 26, 2024 05:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 26, 2024 08:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 26, 2024 08:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 26, 2024 12:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 26, 2024 12:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 26, 2024 12:05 Inactive
@AndyTWF
Copy link
Contributor

AndyTWF commented Jan 31, 2024 •
edited
Loading

Can we get a description of the key changes / issues fixed in the PR, please :)

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 31, 2024

Can we get a description of the key changes / issues fixed in the PR, please :)

updated!

@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 31, 2024 10:35 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 31, 2024 10:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 31, 2024 12:15 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 31, 2024 12:16 Inactive
@sacOO7 sacOO7 force-pushed the fix/no-connection-serial-tests branch from bac486e to 2436f67 Compare January 31, 2024 12:21
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 31, 2024 12:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 31, 2024 12:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 31, 2024 13:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 31, 2024 13:08 Inactive
@sacOO7 sacOO7 force-pushed the fix/no-connection-serial-tests branch from 6f15af0 to e791f8f Compare January 31, 2024 13:26
@github-actions github-actions bot temporarily deployed to staging/pull/984/features January 31, 2024 13:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc January 31, 2024 13:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/features February 4, 2024 14:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc February 4, 2024 14:45 Inactive
@sacOO7 sacOO7 force-pushed the fix/no-connection-serial-tests branch from 1291486 to 68a0944 Compare February 4, 2024 14:46
@github-actions github-actions bot temporarily deployed to staging/pull/984/features February 4, 2024 14:46 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/984/javadoc February 4, 2024 14:47 Inactive
ttypic
ttypic approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

lib/src/test/java/io/ably/lib/test/common/Helpers.java Show resolved Hide resolved
lib/src/test/java/io/ably/lib/test/realtime/RealtimeResumeTest.java Show resolved Hide resolved
@sacOO7 sacOO7 merged commit ada8758 into feature/no-connection-serial Feb 6, 2024
9 checks passed
@sacOO7 sacOO7 deleted the fix/no-connection-serial-tests branch February 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @AndyTWF @ttypic