Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw exception when trying to attach on released channel #973

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Nov 21, 2023

Fixes #971
Resolves SDK-3924
Resolves SDK-3941

@github-actions github-actions bot temporarily deployed to staging/pull/973/features November 21, 2023 23:38 Inactive
@ttypic ttypic force-pushed the throw-exception-on-released-channel branch from d4f4289 to 17b883e Compare November 22, 2023 19:44
@github-actions github-actions bot temporarily deployed to staging/pull/973/features November 22, 2023 19:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/973/javadoc November 22, 2023 19:45 Inactive
@ttypic ttypic requested a review from AndyTWF November 22, 2023 23:30
@ttypic ttypic marked this pull request as ready for review November 22, 2023 23:31
@ttypic ttypic force-pushed the throw-exception-on-released-channel branch from 17b883e to 6dd4461 Compare November 23, 2023 09:44
@github-actions github-actions bot temporarily deployed to staging/pull/973/features November 23, 2023 09:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/973/javadoc November 23, 2023 09:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/973/features November 23, 2023 10:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/973/javadoc November 23, 2023 10:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/973/features November 23, 2023 10:17 Inactive
@ttypic ttypic force-pushed the throw-exception-on-released-channel branch from 6f34e5a to 4082a25 Compare November 23, 2023 10:24
@github-actions github-actions bot temporarily deployed to staging/pull/973/features November 23, 2023 10:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/973/javadoc November 23, 2023 10:25 Inactive
@ttypic ttypic requested review from paddybyers and AndyTWF November 23, 2023 10:49
@ttypic ttypic merged commit 2e5b848 into main Nov 23, 2023
9 checks passed
@ttypic ttypic deleted the throw-exception-on-released-channel branch November 23, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Throw exception on released Ably Channel methods
3 participants