Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Auth): get rid of unnecessary padding removal for Auth tokens #1021

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore(Auth): get rid of unnecessary padding removal for Auth tokens #1021

merged 1 commit into from
Jul 18, 2024

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Jul 18, 2024 •
edited
Loading

Makes ably-java SDK consistent with other SDKs. In other SDKs we use base64 encoding with padding for Auth tokens

@ttypic ttypic requested a review from sacOO7 July 18, 2024 11:12
sacOO7
sacOO7 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ttypic ttypic merged commit 5ff5989 into main Jul 18, 2024
7 of 9 checks passed
@ttypic ttypic deleted the remove-unnecessarry-padding branch July 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttypic @sacOO7