Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include X-Ably-ClientId for each request (RSA7e2) #1019

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat: include X-Ably-ClientId for each request (RSA7e2) #1019

merged 1 commit into from
Jul 18, 2024

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Jul 16, 2024

Resolves #1015

@ttypic ttypic requested a review from sacOO7 July 16, 2024 07:01
@github-actions github-actions bot temporarily deployed to staging/pull/1019/features July 16, 2024 07:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/javadoc July 16, 2024 07:02 Inactive
sacOO7
sacOO7 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@sacOO7 sacOO7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
You should check for failing tests though

@ttypic
Copy link
Contributor Author

ttypic commented Jul 16, 2024

thanks @sacOO7, yeah, looking at it right now, oddly it passes locally

@ttypic ttypic force-pushed the ECO-4862/add-clientId-header branch from 6698f07 to 7531c34 Compare July 18, 2024 08:33
@ttypic ttypic merged commit c2c4125 into main Jul 18, 2024
7 of 9 checks passed
@ttypic ttypic deleted the ECO-4862/add-clientId-header branch July 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For REST clients, all requests should include an X-Ably-ClientId header when basic auth is to be used (RSA7e2)
2 participants
@ttypic @sacOO7