Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.2.39 #1011

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Release/1.2.39 #1011

merged 2 commits into from
Jun 3, 2024

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Jun 3, 2024

No description provided.

@ttypic ttypic requested a review from umair-ably June 3, 2024 08:05
@github-actions github-actions bot temporarily deployed to staging/pull/1011/features June 3, 2024 08:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1011/javadoc June 3, 2024 08:06 Inactive
@ttypic ttypic requested a review from VeskeR June 3, 2024 13:05
VeskeR
VeskeR reviewed Jun 3, 2024
View reviewed changes
Copy link

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttypic do we also need to update version mention in README and in lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (based on release process described in CONTRIBUTING.md and last release commit 2cbdf33)?

@VeskeR
Copy link

VeskeR commented Jun 3, 2024

I mean next lines:

@VeskeR VeskeR self-requested a review June 3, 2024 13:18
VeskeR
VeskeR approved these changes Jun 3, 2024
View reviewed changes
Copy link

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttypic ttypic merged commit 93adeff into main Jun 3, 2024
7 of 9 checks passed
@ttypic ttypic deleted the release/1.2.39 branch June 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeskeR VeskeR VeskeR approved these changes

@umair-ably umair-ably Awaiting requested review from umair-ably

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttypic @VeskeR