Refactored attach channels with right spec

ably · Dec 8, 2023 · 68a9f0a · 68a9f0a
1 parent da67abc
commit 68a9f0a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/lib/src/main/java/io/ably/lib/realtime/AblyRealtime.java b/lib/src/main/java/io/ably/lib/realtime/AblyRealtime.java
@@ -284,6 +284,16 @@ private void clear() {
         }
     }
 
+    // RTN19b
+    protected void reattachChannels() {
+        for (Channel channel : this.channels.values()) {
+            if (channel.state == ChannelState.attaching || channel.state == ChannelState.attached || channel.state == ChannelState.suspended) {
+                Log.d(TAG, "reAttach(); channel = " + channel.name);
+                channel.attach(true, null);
+            }
+        }
+    }
+
     protected void setChannelSerialsFromRecoverOption(Map<String, String> serials) {
         for (Map.Entry<String, String> entry : serials.entrySet()) {
             String channelName = entry.getKey();
@@ -295,15 +305,6 @@ protected void setChannelSerialsFromRecoverOption(Map<String, String> serials) {
         }
     }
 
-    protected void reattachChannels() {
-        for (Channel channel : this.channels.values()) {
-            if (channel.state == ChannelState.attaching || channel.state == ChannelState.attached || channel.state == ChannelState.suspended) {
-                Log.d(TAG, "reAttach(); channel = " + channel.name);
-                channel.attach(true, null);
-            }
-        }
-    }
-
     protected Map<String, String> getChannelSerials() {
         Map<String, String> channelSerials = new HashMap<>();
         for (Channel channel : this.channels.values()) {

diff --git a/lib/src/main/java/io/ably/lib/realtime/Connection.java b/lib/src/main/java/io/ably/lib/realtime/Connection.java
@@ -130,6 +130,9 @@ public void close() {
     public void onConnectionStateChange(ConnectionStateChange stateChange) {
         state = stateChange.current;
         reason = stateChange.reason;
+        if (state == ConnectionState.connected) { // RTN19b
+            ably.reattachChannels();
+        }
         emit(state, stateChange);
     }