Skip to content

Commit

Permalink
Merge pull request #1053 from ably/release/1.2.47
Browse files Browse the repository at this point in the history
Release/1.2.47
  • Loading branch information
ttypic authored Dec 11, 2024
2 parents 6a2ec04 + 06cf9b7 commit 0a1c8bf
Show file tree
Hide file tree
Showing 6 changed files with 53 additions and 6 deletions.
39 changes: 39 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Manual Release to Maven Central

on:
workflow_dispatch:

jobs:
run-on-release:
runs-on: ubuntu-latest

steps:
# Ensure the workflow is being run for a published release
- name: Validate Release
run: |
if [ -z "${{ github.event.release.tag_name }}" ]; then
echo "This workflow must be run in the context of a published release.";
exit 1;
fi
echo "Running workflow for release: ${{ github.event.release.tag_name }}";
- name: Checkout code
uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v4
with:
java-version: 17
distribution: temurin

- name: Set up Gradle
uses: gradle/actions/setup-gradle@v3

- name: Publish and release to Maven Central
run: ./gradlew publishAndReleaseToMavenCentral
env:
ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.SONATYPE_USERNAME }}
ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.SONATYPE_PASSWORD }}
ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_IN_MEMORY_KEY }}
ORG_GRADLE_PROJECT_signingInMemoryKeyId: ${{ secrets.SIGNING_KEY_ID }}
ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_PASSWORD }}
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

## [1.2.47](https://github.com/ably/ably-java/tree/v1.2.47)

[Full Changelog](https://github.com/ably/ably-java/compare/v1.2.46...v1.2.47)

**Fixed bugs:**

- Java SDK - Duplicate messages on rewind after 1.2.34 [\#1050](https://github.com/ably/ably-java/issues/1050)

## [1.2.46](https://github.com/ably/ably-java/tree/v1.2.46)

[Full Changelog](https://github.com/ably/ably-java/compare/v1.2.45...v1.2.46)
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ You may wish to make changes to Ably Java or Ably Android, and test it immediate
- Open the directory printed from the output of that command. Inside that folder, get the `ably-android-x.y.z.aar`, and place it your Android project's `libs/` directory. Create this directory if it doesn't exist.
- Add an `implementation` dependency on the `.aar`:
```groovy
implementation files('libs/ably-android-1.2.46.aar')
implementation files('libs/ably-android-1.2.47.aar')
```
- Add the `implementation` (not `testImplementation`) dependencies found in `dependencies.gradle` to your project. This is because the `.aar` does not contain dependencies.
- Build/run your application.
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ Include the library by adding an `implementation` reference to `dependencies` bl
For [Java](https://mvnrepository.com/artifact/io.ably/ably-java/latest):

```groovy
implementation 'io.ably:ably-java:1.2.46'
implementation 'io.ably:ably-java:1.2.47'
```

For [Android](https://mvnrepository.com/artifact/io.ably/ably-android/latest):

```groovy
implementation 'io.ably:ably-android:1.2.46'
implementation 'io.ably:ably-android:1.2.47'
```

The library is hosted on [Maven Central](https://mvnrepository.com/repos/central), so you need to ensure that the repository is referenced also; IDEs will typically include this by default:
Expand Down Expand Up @@ -512,7 +512,7 @@ Add the following dependency to your `build.gradle` file:

```groovy
dependencies {
runtimeOnly("io.ably:network-client-okhttp:1.2.46")
runtimeOnly("io.ably:network-client-okhttp:1.2.47")
}
```

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GROUP=io.ably
VERSION_NAME=1.2.46
VERSION_NAME=1.2.47

POM_INCEPTION_YEAR=2015
POM_URL=https://github.com/ably/ably-java
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void realtime_websocket_param_test() {
* Defaults.ABLY_AGENT_PARAM, as ultimately the request param has been derived from those values.
*/
assertEquals("Verify correct lib version", requestParameters.get("agent"),
Collections.singletonList("ably-java/1.2.46 jre/" + System.getProperty("java.version")));
Collections.singletonList("ably-java/1.2.47 jre/" + System.getProperty("java.version")));

/* Spec RTN2a */
assertEquals("Verify correct format", requestParameters.get("format"),
Expand Down

0 comments on commit 0a1c8bf

Please sign in to comment.