Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4611] Feature/integration 2.0 #508

Merged
merged 15 commits into from
Mar 5, 2024
Merged

[ECO-4611] Feature/integration 2.0 #508

merged 15 commits into from
Mar 5, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Feb 27, 2024 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/508/features February 27, 2024 10:52 Inactive
@sacOO7 sacOO7 mentioned this pull request Feb 27, 2024
Closed
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc February 27, 2024 10:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features February 27, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc February 27, 2024 10:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features February 27, 2024 11:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc February 27, 2024 11:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features February 28, 2024 10:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc February 28, 2024 10:04 Inactive
@jamienewcomb jamienewcomb changed the title Feature/integration 2.0 [ECO-4611] Feature/integration 2.0 Feb 28, 2024
@sacOO7 sacOO7 mentioned this pull request Feb 28, 2024
Closed
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 4, 2024 20:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 4, 2024 20:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 04:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 04:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 08:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 08:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 10:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 10:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 10:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 10:27 Inactive
@sacOO7 sacOO7 force-pushed the feature/integration-2.0 branch from fce5a90 to fd7cc8c Compare March 5, 2024 10:29
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 10:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 10:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 11:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 11:03 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review March 5, 2024 11:19
@sacOO7 sacOO7 requested review from ttypic and maratal March 5, 2024 11:19
ttypic
ttypic approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot temporarily deployed to staging/pull/508/features March 5, 2024 13:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/508/dartdoc March 5, 2024 13:55 Inactive
@sacOO7 sacOO7 force-pushed the feature/integration-2.0 branch from 3e42fd0 to d3cd37b Compare March 5, 2024 13:56
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Mar 5, 2024

Thanks for the review : )

@sacOO7 sacOO7 merged commit af60beb into main Mar 5, 2024
8 checks passed
@sacOO7 sacOO7 deleted the feature/integration-2.0 branch March 5, 2024 14:21
@sacOO7 sacOO7 mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@maratal maratal Awaiting requested review from maratal

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ably-flutter] Implement no-connection-serial
2 participants
@sacOO7 @ttypic