Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme #1256

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Fix readme #1256

merged 9 commits into from
Sep 15, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Aug 19, 2023 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/1256/features August 19, 2023 18:37 Inactive
@sacOO7 sacOO7 mentioned this pull request Aug 19, 2023
Closed
@github-actions github-actions bot temporarily deployed to staging/pull/1256/features August 19, 2023 18:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1256/features August 20, 2023 13:21 Inactive
@sacOO7 sacOO7 requested review from owenpearson and AndyTWF August 21, 2023 16:50
@github-actions github-actions bot temporarily deployed to staging/pull/1256/features August 30, 2023 14:18 Inactive
owenpearson
owenpearson requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for wording:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1256/features August 30, 2023 17:45 Inactive
@sacOO7 sacOO7 requested a review from owenpearson August 30, 2023 17:50
owenpearson
owenpearson approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sacOO7 sacOO7 merged commit b359101 into main Sep 15, 2023
@sacOO7 sacOO7 deleted the update/json-serialize-readme branch September 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdmarc fdmarc fdmarc approved these changes

@owenpearson owenpearson owenpearson approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @owenpearson @fdmarc