Refactored AblyHttpClient code as per review comments

ably · Apr 19, 2024 · 4d06b27 · 4d06b27
1 parent 9a80c7e
commit 4d06b27
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/IO.Ably.Shared/Http/AblyHttpClient.cs b/src/IO.Ably.Shared/Http/AblyHttpClient.cs
@@ -85,10 +85,10 @@ public async Task<AblyResponse> Execute(AblyRequest request)
         {
             var fallbackHosts = GetFallbackHosts();
 
-            int currentTry = 0;
+            int currentTry = 0; 
             var startTime = Now();
 
-            var maxNumberOfRetries = Options.HttpMaxRetryCount; // One for the first request
+            var maxNumberOfRetries = Options.HttpMaxRetryCount;
             var host = GetHost();
 
             request.Headers.TryGetValue("request_id", out var requestId);
@@ -148,7 +148,7 @@ public async Task<AblyResponse> Execute(AblyRequest request)
                     throw new AblyException(new ErrorInfo(WrapWithRequestId("Error executing request. " + ex.Message), ErrorCodes.InternalError), ex);
                 }
             }
-            while (currentTry <= maxNumberOfRetries);
+            while (currentTry <= maxNumberOfRetries); // 1 primary host and remaining fallback hosts
 
             throw new AblyException(new ErrorInfo(WrapWithRequestId("Error executing request, exceeded max no. of retries"), ErrorCodes.InternalError));