Delete unnecessary recover error test

The test removed in this commit expects that using an invalid recovery key leads to an ERROR protocol message being returned which thus fails the connection, but this isn't part of the spec, we make no guarantee that invalid recovery keys are rejected, and in fact returning a CONNECTED protocol message with the error field indicating the recovery key was invalid is a perfectly good response, which is in fact what we will start to do in the future. The functionality that an ERROR protocol message is treated as fatal and fails the connection is still tested elsewhere, so rmeoving this test doesn't materially reduce the amount of test coverage. Signed-off-by: Lewis Marshall <[email protected]>
ably · Aug 13, 2024 · 3c10353 · 3c10353
1 parent 092240b
commit 3c10353
Showing 1 changed file with 0 additions and 31 deletions.
diff --git a/src/IO.Ably.Tests.Shared/Realtime/ConnectionSandBoxSpecs.cs b/src/IO.Ably.Tests.Shared/Realtime/ConnectionSandBoxSpecs.cs
@@ -1119,37 +1119,6 @@ public async Task WithDummyRecoverData_ShouldConnectAndSetAReasonOnTheConnection
             client.Connection.ErrorReason.Code.Should().Be(ErrorCodes.InvalidFormatForConnectionId);
         }
 
-        [Theory]
-        [ProtocolData]
-        [Trait("spec", "RTN16l")]
-        [Trait("spec", "RTN15c4")]
-        public async Task WithInvalidRecoverData_ShouldFailAndSetAReasonOnTheConnection(Protocol protocol)
-        {
-            var client = await GetRealtimeClient(protocol, (opts, _) =>
-            {
-                opts.Recover = "{\"connectionKey\":\"random_key\",\"msgSerial\":5,\"channelSerials\":{\"channel1\":\"98\",\"channel2\":\"32\",\"channel3\":\"09\"}}";
-                opts.AutoConnect = false;
-            });
-
-            ErrorInfo err = null;
-            client.Connection.On((args) =>
-            {
-                err = args.Reason;
-                if (args.Current == ConnectionState.Failed)
-                {
-                    ResetEvent.Set();
-                }
-            });
-            client.Connect();
-
-            var result = ResetEvent.WaitOne(10000);
-            result.Should().BeTrue("Timeout");
-            err.Should().NotBeNull();
-            err.Code.Should().Be(ErrorCodes.InvalidFormatForConnectionId);
-            client.Connection.ErrorReason.Code.Should().Be(ErrorCodes.InvalidFormatForConnectionId);
-            client.Connection.State.Should().Be(ConnectionState.Failed);
-        }
-
         [Theory]
         [ProtocolData]
         [Trait("issue", "65")]