Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF-3250] - Add Token Revocation parameter for Ably Keys #27

Merged

Conversation

graham-russell
Copy link
Member

Ably keys support token revocation. This commit updates the ably-control-go SDK to allow configuring token revocation for Ably Keys.

Ably key tests have also been updated with the Token revocation parameter.

More information on Token Revocation can be found in the Ably documentation

@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch from 397f91b to 5ca7907 Compare January 31, 2024 09:50
@graham-russell graham-russell marked this pull request as draft January 31, 2024 09:56
@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch 2 times, most recently from a4b17f2 to 681b1ad Compare February 1, 2024 09:53
@graham-russell graham-russell marked this pull request as ready for review February 1, 2024 10:03
keys.go Outdated Show resolved Hide resolved
keys_test.go Show resolved Hide resolved
Ably keys support token revocation. This commit updates ably-control-go to allow configuring this.

Ably key tests have also been updated with the Token revocation parameter.

More information on Token Revocation can be found in the Ably documentation https://ably.com/docs/auth/revocation
@graham-russell graham-russell force-pushed the feature/INF-3250-add-ably-key-revocable-tokens-param branch from 681b1ad to 9537245 Compare February 1, 2024 10:35
Copy link
Contributor

@surminus surminus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@graham-russell graham-russell merged commit 3cf28e6 into main Feb 1, 2024
2 checks passed
@graham-russell graham-russell deleted the feature/INF-3250-add-ably-key-revocable-tokens-param branch February 1, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants